safety-screen/Nominatim
1
0
Fork 0
forked from hans/Nominatim
Code Pull Requests Activity

add unknown addr:place to address output

Browse Source 
When a POI has no addr:street but an addr:place that is not
contained in the name list of the parent place, then remember
this situation and merge the content of addr:place into the
address output.

We don't need to care about translations in this case because
it is obvious that no object with translations exists if the
parent isn't the object named in addr:place.
This commit is contained in:
Sarah Hoffmann
2020-09-23 11:55:18 +02:00
parent f2ff351da4
commit c84e7e72f1
3 changed files with 41 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
test/bdd/db/import/search_name.feature
View File

@@ -27,8 +27,8 @@ Feature: Creation of search terms
| N1 | #23 | Rose Street, Walltown |
When searching for "23 Rose Street, Walltown"
Then results contain
| osm_type | osm_id |
| N | 1 |
| osm_type | osm_id | name |
| N | 1 | 23, Rose Street |
Scenario: Unnamed POI has no search entry when it has known addr: tags
Given the scene roads-with-pois
@@ -42,8 +42,8 @@ Feature: Creation of search terms
Then search_name has no entry for N1
When searching for "23 Rose Street, Walltown"
Then results contain
| osm_type | osm_id |
| N | 1 |
| osm_type | osm_id | name |
| N | 1 | 23, Rose Street |
Scenario: Unnamed POI must have a house number to get a search entry
Given the scene roads-with-pois
@@ -72,12 +72,12 @@ Feature: Creation of search terms
When searching for "23 Rose Street"
Then exactly 1 results are returned
And results contain
| osm_type | osm_id |
| W | 1 |
| osm_type | osm_id | name |
| W | 1 | Rose Street, Strange Town |
When searching for "23 Walltown"
Then results contain
| osm_type | osm_id |
| N | 1 |
| osm_type | osm_id | name |
| N | 1 | 23, Walltown, Strange Town |
Scenario: Unnamed POIs doesn't inherit parent name when addr:place is present only in parent address
Given the scene roads-with-pois
@@ -95,13 +95,13 @@ Feature: Creation of search terms
When searching for "23 Rose Street, Walltown"
Then exactly 1 result is returned
And results contain
| osm_type | osm_id |
| W | 1 |
| osm_type | osm_id | name |
| W | 1 | Rose Street, Strange Town |
When searching for "23 Walltown"
Then exactly 1 result is returned
And results contain
| osm_type | osm_id |
| N | 1 |
| osm_type | osm_id | name |
| N | 1 | 23, Walltown, Strange Town |
Scenario: Unnamed POIs does inherit parent name when unknown addr:place and addr:street is present
Given the scene roads-with-pois
@@ -115,8 +115,8 @@ Feature: Creation of search terms
Then search_name has no entry for N1
When searching for "23 Rose Street"
Then results contain
| osm_type | osm_id |
| N | 1 |
| osm_type | osm_id | name |
| N | 1 | 23, Rose Street |
When searching for "23 Lily Street"
Then exactly 0 results are returned
@@ -132,8 +132,8 @@ Feature: Creation of search terms
Then search_name has no entry for N1
When searching for "23 Rose Street"
Then results contain
| osm_type | osm_id |
| N | 1 |
| osm_type | osm_id | name |
| N | 1 | 23, Rose Street |
When searching for "23 Lily Street"
Then exactly 0 results are returned
@@ -151,8 +151,8 @@ Feature: Creation of search terms
| N1 | #Green Moss | Rose Street, Walltown |
When searching for "Green Moss, Rose Street, Walltown"
Then results contain
| osm_type | osm_id |
| N | 1 |
| osm_type | osm_id | name |
| N | 1 | Green Moss, Rose Street |
Scenario: Named POI doesn't inherit parent name when addr:place is present only in parent address
Given the scene roads-with-pois
@@ -171,8 +171,8 @@ Feature: Creation of search terms
Then exactly 0 result is returned
When searching for "Green Moss, Walltown"
Then results contain
| osm_type | osm_id |
| N | 1 |
| osm_type | osm_id | name |
| N | 1 | Green Moss, Walltown, Strange Town |
Scenario: Named POIs inherit address from parent
Given the scene roads-with-pois