safety-screen/Nominatim
1
0
Fork 0
forked from hans/Nominatim
Code Pull Requests Activity

expand details BDD tests

Browse Source 
There are now minor differences in the output between PHP and
Python versions, so introduce specific tests.
This commit is contained in:
Sarah Hoffmann
2023-02-03 21:59:16 +01:00
parent 3ac70f7cc2
commit b742200442
4 changed files with 97 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
test/bdd/api/details/params.feature
View File

@@ -7,6 +7,9 @@ Feature: Object details
Then the result is valid json
And result has attributes geometry
And result has not attributes keywords,address,linked_places,parentof
And results contain
| geometry+type |
| Point |
Scenario: JSON Details with pretty printing
When sending json details query for W297699560
@@ -64,6 +67,7 @@ Feature: Object details
| keywords |
| 1 |
Then the result is valid json
And result has attributes keywords
Scenario Outline: JSON details with full geometry
When sending json details query for <osmid>
@@ -71,12 +75,15 @@ Feature: Object details
| 1 |
Then the result is valid json
And result has attributes geometry
And results contain
| geometry+type |
| <geometry> |
Examples:
| osmid |
| W297699560 |
| W243055645 |
| W243055716 |
| W43327921 |
| osmid | geometry |
| W297699560 | LineString |
| W243055645 | Polygon |
| W243055716 | Polygon |
| W43327921 | LineString |

62
test/bdd/api/details/simple.feature
View File

@@ -9,6 +9,7 @@ Feature: Object details
| place_id |
| 107077 |
Scenario Outline: Details via OSM id
When sending details query for <type><id>
Then the result is valid json
@@ -22,12 +23,6 @@ Feature: Object details
| W | 43327921 |
| R | 123924 |
Scenario: Details for interpolation way just return the dependent street
When sending details query for W1
Then the result is valid json
And results contain
| category |
| highway |
Scenario Outline: Details for different class types for the same OSM id
When sending details query for N300209696:<class>
@@ -42,6 +37,7 @@ Feature: Object details
| natural |
| mountain_pass |
Scenario Outline: Details via unknown OSM id
When sending details query for <object>
Then a HTTP 404 is returned
@@ -53,3 +49,57 @@ Feature: Object details
| N300209696:highway |
@v1-api-php-only
Scenario: Details for interpolation way just return the dependent street
When sending details query for W1
Then the result is valid json
And results contain
| category |
| highway |
@v1-api-python-only
Scenario: Details for interpolation way return the interpolation
When sending details query for W1
Then the result is valid json
And results contain
| category | type | osm_type | osm_id | admin_level |
| place | houses | W | 1 | 15 |
@v1-api-php-only
Scenario: Details for Tiger way just return the dependent street
When sending details query for 112871
Then the result is valid json
And results contain
| category |
| highway |
@v1-api-python-only
Scenario: Details for interpolation way return the interpolation
When sending details query for 112871
Then the result is valid json
And results contain
| category | type | admin_level |
| place | houses | 15 |
And result has not attributes osm_type,osm_id
@v1-api-php-only
Scenario: Details for postcodes just return the dependent place
When sending details query for 112820
Then the result is valid json
And results contain
| category |
| boundary |
@v1-api-python-only
Scenario: Details for interpolation way return the interpolation
When sending details query for 112820
Then the result is valid json
And results contain
| category | type | admin_level |
| place | postcode | 15 |
And result has not attributes osm_type,osm_id