hans/Nominatim
1
0
Fork 1
mirror of https://github.com/osm-search/Nominatim.git synced 2026-03-06 18:14:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

use place type of for result object in address parts

Browse Source 
Boundaries shound derive the address part type from the
linked place if possible. This was already implemented
for the address objects but not for the address information
from the address itself.

Fixes #1949.
This commit is contained in:
Sarah Hoffmann
2020-09-17 18:17:01 +02:00
parent df115c73b2
commit fe8566928e
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sql/functions/address_lookup.sql
View File

@@ -180,6 +180,7 @@ BEGIN
-- Return the record for the base entry. -- Return the record for the base entry.
FOR location IN FOR location IN
SELECT placex.place_id, osm_type, osm_id, name, SELECT placex.place_id, osm_type, osm_id, name,
coalesce(extratags->'linked_place', extratags->'place') as place_type,
class, type, admin_level, class, type, admin_level,
type not in ('postcode', 'postal_code') as isaddress, type not in ('postcode', 'postal_code') as isaddress,
CASE WHEN rank_address = 0 THEN 100 CASE WHEN rank_address = 0 THEN 100
@@ -198,7 +199,8 @@ BEGIN
searchcountrycode := NULL; searchcountrycode := NULL;
END IF; END IF;
countrylocation := ROW(location.place_id, location.osm_type, location.osm_id, countrylocation := ROW(location.place_id, location.osm_type, location.osm_id,
location.name, location.class, location.type, NULL, location.name, location.class, location.type,
location.place_type,
location.admin_level, true, location.isaddress, location.admin_level, true, location.isaddress,
location.rank_address, location.distance)::addressline; location.rank_address, location.distance)::addressline;
RETURN NEXT countrylocation; RETURN NEXT countrylocation;

8
test/bdd/api/search/queries.feature
View File

@@ -182,3 +182,11 @@ Feature: Search queries
Then results contain Then results contain
| class | type | | class | type |
| highway | residential | | highway | residential |
# github #1949
Scenario: Addressdetails always return the place type
When sending json search query "Rotherbaum" with address
Then result addresses contain
| ID | suburb |
| 0 | Rotherbaum |