hans/Nominatim
1
0
Fork 1
mirror of https://github.com/osm-search/Nominatim.git synced 2026-02-15 19:07:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

do not return POIs when dropping house number in query

Browse Source 
We've previously added searching through rank 30 in a house
number search to enable searches for house number+name.
This had the unintended side effect that rank 30 objects
are also returned in s search that dropped the house number
from the query. This is wrong because POIs cannot function
as a parent to a house number.

This fix drops all rank 30 objects from the results for a
house number search if they do not match the requested house
number.
This commit is contained in:
Sarah Hoffmann
2021-06-17 12:05:33 +02:00
parent 38fbc4fcbb
commit fe11d3cbbd
3 changed files with 88 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
test/bdd/db/query/search_simple.feature
View File

@@ -45,3 +45,30 @@ Feature: Searching of simple objects
Then result addresses contain
| amenity | road |
| Bean | The build |
Scenario: when missing housenumbers in search don't return a POI
Given the places
| osm | class | type | name |
| N3 | amenity | restaurant | Wood Street |
And the places
| osm | class | type | name | housenr |
| N20 | amenity | restaurant | Red Way | 34 |
When importing
And sending search query "Wood Street 45"
Then exactly 0 results are returned
When sending search query "Red Way 34"
Then results contain
| osm |
| N20 |
Scenario: when the housenumber is missing the stret is still returned
Given the grid
| 1 | | 2 |
Given the places
| osm | class | type | name | geometry |
| W1 | highway | residential | Wood Street | 1, 2 |
When importing
And sending search query "Wood Street"
Then results contain
| osm |
| W1 |