port database setup function to python

Hide the former PHP functions in a transition command until
they are removed.

test/Makefile

@@ -10,5 +10,8 @@ bdd-no-test-db:
 php:
 	cd php && phpunit ./
 
+python:
+	pytest python
+
 
 .PHONY: bdd php no-test-db

test/python/conftest.py

@@ -105,6 +105,9 @@ def temp_db_cursor(temp_db):
 def def_config():
     return Configuration(None, SRC_DIR.resolve() / 'settings')
 
+@pytest.fixture
+def src_dir():
+    return SRC_DIR.resolve()
 
 @pytest.fixture
 def status_table(temp_db_conn):

test/python/test_cli.py

@@ -6,9 +6,11 @@ correct functionionality. They use a lot of monkeypatching to avoid executing
 the actual functions.
 """
 import datetime as dt
+import time
+from pathlib import Path
+
 import psycopg2
 import pytest
-import time
 
 import nominatim.cli
 import nominatim.clicmd.api
@@ -23,14 +25,16 @@ import nominatim.tools.replication
 from nominatim.errors import UsageError
 from nominatim.db import status
 
+SRC_DIR = (Path(__file__) / '..' / '..' / '..').resolve()
+
 def call_nominatim(*args):
     return nominatim.cli.nominatim(module_dir='build/module',
                                    osm2pgsql_path='build/osm2pgsql/osm2pgsql',
-                                   phplib_dir='lib-php',
-                                   data_dir='.',
+                                   phplib_dir=str(SRC_DIR / 'lib-php'),
+                                   data_dir=str(SRC_DIR / 'data'),
                                    phpcgi_path='/usr/bin/php-cgi',
-                                   sqllib_dir='lib-sql',
-                                   config_dir='settings',
+                                   sqllib_dir=str(SRC_DIR / 'lib-sql'),
+                                   config_dir=str(SRC_DIR / 'settings'),
                                    cli_args=args)
 
 class MockParamCapture:

test/python/test_db_connection.py

@@ -37,6 +37,17 @@ def test_connection_server_version_tuple(db):
     assert len(ver) == 2
     assert ver[0] > 8
 
+
+def test_connection_postgis_version_tuple(db, temp_db_cursor):
+    temp_db_cursor.execute('CREATE EXTENSION postgis')
+
+    ver = db.postgis_version_tuple()
+
+    assert isinstance(ver, tuple)
+    assert len(ver) == 2
+    assert ver[0] >= 2
+
+
 def test_cursor_scalar(db, temp_db_cursor):
     temp_db_cursor.execute('CREATE TABLE dummy (id INT)')
 

test/python/test_db_utils.py

@@ -26,6 +26,7 @@ def test_execute_file_bad_file(dsn, tmp_path):
     with pytest.raises(FileNotFoundError):
         db_utils.execute_file(dsn, tmp_path / 'test2.sql')
 
+
 def test_execute_file_bad_sql(dsn, tmp_path):
     tmpfile = tmp_path / 'test.sql'
     tmpfile.write_text('CREATE STABLE test (id INT)')

test/python/test_tools_database_import.py

@@ -0,0 +1,96 @@
+"""
+Tests for functions to import a new database.
+"""
+import pytest
+import psycopg2
+import sys
+
+from nominatim.tools import database_import
+from nominatim.errors import UsageError
+
+@pytest.fixture
+def nonexistant_db():
+    dbname = 'test_nominatim_python_unittest'
+
+    conn = psycopg2.connect(database='postgres')
+
+    conn.set_isolation_level(0)
+    with conn.cursor() as cur:
+        cur.execute('DROP DATABASE IF EXISTS {}'.format(dbname))
+
+    yield dbname
+
+    with conn.cursor() as cur:
+        cur.execute('DROP DATABASE IF EXISTS {}'.format(dbname))
+
+
+def test_create_db_success(nonexistant_db):
+    database_import.create_db('dbname=' + nonexistant_db, rouser='www-data')
+
+    conn = psycopg2.connect(database=nonexistant_db)
+    conn.close()
+
+
+def test_create_db_already_exists(temp_db):
+    with pytest.raises(UsageError):
+        database_import.create_db('dbname=' + temp_db)
+
+
+def test_create_db_unsupported_version(nonexistant_db, monkeypatch):
+    monkeypatch.setattr(database_import, 'POSTGRESQL_REQUIRED_VERSION', (100, 4))
+
+    with pytest.raises(UsageError, match='PostgreSQL server is too old.'):
+        database_import.create_db('dbname=' + nonexistant_db)
+
+
+def test_create_db_missing_ro_user(nonexistant_db):
+    with pytest.raises(UsageError, match='Missing read-only user.'):
+        database_import.create_db('dbname=' + nonexistant_db, rouser='sdfwkjkjgdugu2;jgsafkljas;')
+
+
+def test_setup_extensions(temp_db_conn, temp_db_cursor):
+    database_import.setup_extensions(temp_db_conn)
+
+    temp_db_cursor.execute('CREATE TABLE t (h HSTORE, geom GEOMETRY(Geometry, 4326))')
+
+
+def test_setup_extensions_old_postgis(temp_db_conn, monkeypatch):
+    monkeypatch.setattr(database_import, 'POSTGIS_REQUIRED_VERSION', (50, 50))
+
+    with pytest.raises(UsageError, match='PostGIS version is too old.'):
+        database_import.setup_extensions(temp_db_conn)
+
+
+def test_install_module(tmp_path):
+    src_dir = tmp_path / 'source'
+    src_dir.mkdir()
+    (src_dir / 'nominatim.so').write_text('TEST nomiantim.so')
+
+    project_dir = tmp_path / 'project'
+    project_dir.mkdir()
+
+    database_import.install_module(src_dir, project_dir, '')
+
+    outfile = project_dir / 'module' / 'nominatim.so'
+
+    assert outfile.exists()
+    assert outfile.read_text() == 'TEST nomiantim.so'
+    assert outfile.stat().st_mode == 33261
+
+
+def test_import_base_data(src_dir, temp_db, temp_db_cursor):
+    temp_db_cursor.execute('CREATE EXTENSION hstore')
+    temp_db_cursor.execute('CREATE EXTENSION postgis')
+    database_import.import_base_data('dbname=' + temp_db, src_dir / 'data')
+
+    assert temp_db_cursor.scalar('SELECT count(*) FROM country_name') > 0
+
+
+def test_import_base_data_ignore_partitions(src_dir, temp_db, temp_db_cursor):
+    temp_db_cursor.execute('CREATE EXTENSION hstore')
+    temp_db_cursor.execute('CREATE EXTENSION postgis')
+    database_import.import_base_data('dbname=' + temp_db, src_dir / 'data',
+                                     ignore_partitions=True)
+
+    assert temp_db_cursor.scalar('SELECT count(*) FROM country_name') > 0
+    assert temp_db_cursor.scalar('SELECT count(*) FROM country_name WHERE partition != 0') == 0