hans/Nominatim
1
0
Fork 1
mirror of https://github.com/osm-search/Nominatim.git synced 2026-02-16 15:47:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove support for sanic framework

Browse Source 
There is no performance gain over falcon or starlette but the special
structure of sanic makes it hard to have exchangable code
This commit is contained in:
Sarah Hoffmann
2023-06-21 10:53:57 +02:00
parent ded2c5bf68
commit b79d5494f9
8 changed files with 8 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/bdd/steps/nominatim_environment.py
View File

@@ -350,20 +350,6 @@ class NominatimEnvironment:
return _request
def create_api_request_func_sanic(self):
import nominatim.server.sanic.server
async def _request(endpoint, params, project_dir, environ, http_headers):
app = nominatim.server.sanic.server.get_application(project_dir, environ)
_, response = await app.asgi_client.get(f"/{endpoint}", params=params,
headers=http_headers)
return response.text, response.status_code
return _request
def create_api_request_func_falcon(self):
import nominatim.server.falcon.server
import falcon.testing

9
test/python/cli/test_cli.py
View File

@@ -68,15 +68,6 @@ def test_cli_serve_php(cli_call, mock_func_factory):
assert func.called == 1
def test_cli_serve_sanic(cli_call, mock_func_factory):
mod = pytest.importorskip("sanic")
func = mock_func_factory(mod.Sanic, "run")
cli_call('serve', '--engine', 'sanic') == 0
assert func.called == 1
def test_cli_serve_starlette_custom_server(cli_call, mock_func_factory):
pytest.importorskip("starlette")
mod = pytest.importorskip("uvicorn")