hans/Nominatim
1
0
Fork 1
mirror of https://github.com/osm-search/Nominatim.git synced 2026-02-16 15:47:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

lonvia PR feedback

Browse Source
This commit is contained in:
marc tobias
2020-04-26 03:33:15 +02:00
parent 38c21de0ee
commit a5d0657d9b
4 changed files with 25 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/README.md
View File

@@ -51,8 +51,8 @@ To execute the test suite run
It will read phpunit.xml which points to the library, test path, bootstrap
strip and set other parameters.
The database set by `UNIT_TEST_DSN` will be deleted and recreated. Not setting
it will skip some tests as pending, but not fail the tests.
It will use (and destroy) a local database 'nominatim_unit_tests'. You can set
a different connection string with e.g. UNIT_TEST_DSN='pgsql:dbname=foo_unit_tests'.
BDD Functional Tests
====================

14
test/php/Nominatim/DBTest.php
View File

@@ -128,11 +128,19 @@ class DBTest extends \PHPUnit\Framework\TestCase
public function testAgainstDatabase()
{
if (getenv('UNIT_TEST_DSN') == false) $this->markTestSkipped('UNIT_TEST_DSN not set');
$unit_test_dsn = getenv('UNIT_TEST_DSN') != false ?
getenv('UNIT_TEST_DSN') :
'pgsql:dbname=nominatim_unit_tests';
$this->assertRegExp(
'/unit_test/',
$unit_test_dsn,
'Test database will get destroyed, thus should have a name like unit_test to be safe'
);
## Create the database.
{
$aDSNParsed = \Nominatim\DB::parseDSN(getenv('UNIT_TEST_DSN'));
$aDSNParsed = \Nominatim\DB::parseDSN($unit_test_dsn);
$sDbname = $aDSNParsed['database'];
$aDSNParsed['database'] = 'postgres';
@@ -142,7 +150,7 @@ class DBTest extends \PHPUnit\Framework\TestCase
$oDB->exec('CREATE DATABASE ' . $sDbname);
}
$oDB = new \Nominatim\DB(getenv('UNIT_TEST_DSN'));
$oDB = new \Nominatim\DB($unit_test_dsn);
$oDB->connect();
$this->assertTrue(