use ISO3166-2-lvl<admin_level> instead of typeLabel prefix

This commit is contained in:
Artem Ziablytskyi
2022-04-06 19:24:39 +02:00
committed by Sarah Hoffmann
parent 7899654675
commit 9a56e53d50
6 changed files with 13 additions and 9 deletions

View File

@@ -28,7 +28,7 @@ a single place (for reverse) of the following format:
"city": "London", "city": "London",
"state_district": "Greater London", "state_district": "Greater London",
"state": "England", "state": "England",
"state-ISO3166-2": "GB-ENG", "ISO3166-2-lvl4": "GB-ENG",
"postcode": "SW1A 2DU", "postcode": "SW1A 2DU",
"country": "United Kingdom", "country": "United Kingdom",
"country_code": "gb" "country_code": "gb"
@@ -127,7 +127,7 @@ formats depending on the API call.
</result> </result>
<addressparts> <addressparts>
<state>Bavaria</state> <state>Bavaria</state>
<state-ISO3166-2>DE-BY</state_code> <ISO3166-2-lvl4>DE-BY</state_code>
<country>Germany</country> <country>Germany</country>
<country_code>de</country_code> <country_code>de</country_code>
</addressparts> </addressparts>
@@ -181,7 +181,7 @@ Additional information requested with `addressdetails=1`, `extratags=1` and
<city>London</city> <city>London</city>
<state_district>Greater London</state_district> <state_district>Greater London</state_district>
<state>England</state> <state>England</state>
<state-ISO3166-2>GB-ENG</state_code> <ISO3166-2-lvl4>GB-ENG</state_code>
<postcode>SW1A 2DU</postcode> <postcode>SW1A 2DU</postcode>
<country>United Kingdom</country> <country>United Kingdom</country>
<country_code>gb</country_code> <country_code>gb</country_code>
@@ -282,7 +282,7 @@ with a designation label. Per default the following labels may appear:
* continent * continent
* country, country_code * country, country_code
* region, state, state-ISO3166-2, state_district, county, county-ISO3166-2 * region, state, state_district, county, ISO3166-2-lvl<admin_level>
* municipality, city, town, village * municipality, city, town, village
* city_district, district, borough, suburb, subdivision * city_district, district, borough, suburb, subdivision
* hamlet, croft, isolated_dwelling * hamlet, croft, isolated_dwelling

View File

@@ -94,7 +94,7 @@ class AddressDetails
$aAddress[$sTypeLabel] = $sName; $aAddress[$sTypeLabel] = $sName;
if (!empty($aLine['name'])) { if (!empty($aLine['name'])) {
$this->addSubdivisionCode($aAddress, $sTypeLabel, $aLine['name']); $this->addSubdivisionCode($aAddress, $aLine['admin_level'], $aLine['name']);
} }
} }
} }
@@ -179,13 +179,13 @@ class AddressDetails
return $this->aAddressLines; return $this->aAddressLines;
} }
private function addSubdivisionCode(&$aAddress, $sTypeLabel, $nameDetails) private function addSubdivisionCode(&$aAddress, $iAdminLevel, $nameDetails)
{ {
if (is_string($nameDetails)) { if (is_string($nameDetails)) {
$nameDetails = json_decode('{' . str_replace('"=>"', '":"', $nameDetails) . '}', true); $nameDetails = json_decode('{' . str_replace('"=>"', '":"', $nameDetails) . '}', true);
} }
if (!empty($nameDetails['ISO3166-2'])) { if (!empty($nameDetails['ISO3166-2'])) {
$aAddress["$sTypeLabel-ISO3166-2"] = $nameDetails['ISO3166-2']; $aAddress["ISO3166-2-lvl$iAdminLevel"] = $nameDetails['ISO3166-2'];
} }
} }
} }

View File

@@ -34,6 +34,7 @@ Feature: Search queries
| postcode | 9495 | | postcode | 9495 |
| country | Liechtenstein | | country | Liechtenstein |
| country_code | li | | country_code | li |
| ISO3166-2-lvl12 | LI-09 |
Examples: Examples:
| format | | format |

View File

@@ -15,6 +15,7 @@ Feature: Search queries
| postcode | 9497 | | postcode | 9497 |
| country | Liechtenstein | | country | Liechtenstein |
| country_code | li | | country_code | li |
| ISO3166-2-lvl10 | LI-10 |
Scenario: House number interpolation Scenario: House number interpolation
When sending json search query "Grosssteg 1023, Triesenberg" with address When sending json search query "Grosssteg 1023, Triesenberg" with address
@@ -41,6 +42,7 @@ Feature: Search queries
| town | Triesenberg | | town | Triesenberg |
| country | Liechtenstein | | country | Liechtenstein |
| country_code | li | | country_code | li |
| ISO3166-2-lvl10 | LI-10 |
Scenario Outline: Housenumber 0 can be found Scenario Outline: Housenumber 0 can be found
When sending <format> search query "Gnalpstrasse 0" with address When sending <format> search query "Gnalpstrasse 0" with address

View File

@@ -86,7 +86,8 @@ class AddressDetailsTest extends \PHPUnit\Framework\TestCase
'city' => 'London', 'city' => 'London',
'state_district' => 'Greater London', 'state_district' => 'Greater London',
'state' => 'England', 'state' => 'England',
'state-ISO3166-2' => 'GB-ENG', 'ISO3166-2-lvl4' => 'GB-ENG',
'ISO3166-2-lvl6' => 'GB-LND',
'postcode' => 'SW1A 2AA', 'postcode' => 'SW1A 2AA',
'country' => 'United Kingdom', 'country' => 'United Kingdom',
'country_code' => 'gb' 'country_code' => 'gb'

View File

@@ -133,7 +133,7 @@
{"place_id":193774423, {"place_id":193774423,
"osm_type":"R", "osm_type":"R",
"osm_id":65606, "osm_id":65606,
"name":{"name": "London", "name:be": "Лондан", "name:ca": "Londres", "name:el": "Λονδίνο", "name:en": "London", "name:eo": "Londono", "name:es": "Londres", "name:fa": "لندن", "name:fi": "Lontoo", "name:fr": "Londres", "name:fy": "Londen", "name:gl": "Londres", "name:hi": "लंदन", "name:lt": "Londonas", "name:nl": "Londen", "name:pl": "Londyn", "name:pt": "Londres", "name:ru": "Лондон", "name:uk": "Лондон", "name:vi": "Luân Đôn", "name:zh": "伦敦", "int_name": "London", "name:szl": "Lůndůn", "name:tzl": "Londra", "name:be-tarask": "Лёндан"}, "name":{"name": "London", "ISO3166-2": "GB-LND", "name:be": "Лондан", "name:ca": "Londres", "name:el": "Λονδίνο", "name:en": "London", "name:eo": "Londono", "name:es": "Londres", "name:fa": "لندن", "name:fi": "Lontoo", "name:fr": "Londres", "name:fy": "Londen", "name:gl": "Londres", "name:hi": "लंदन", "name:lt": "Londonas", "name:nl": "Londen", "name:pl": "Londyn", "name:pt": "Londres", "name:ru": "Лондон", "name:uk": "Лондон", "name:vi": "Luân Đôn", "name:zh": "伦敦", "int_name": "London", "name:szl": "Lůndůn", "name:tzl": "Londra", "name:be-tarask": "Лёндан"},
"class":"place", "class":"place",
"type":"city", "type":"city",
"admin_level":6, "admin_level":6,