hans/Nominatim
1
0
Fork 1
mirror of https://github.com/osm-search/Nominatim.git synced 2026-02-26 11:08:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

search postcodes for highway areas around the area

Browse Source 
So far the code would only accept postcodes that are inside the area.

Fixes #3304.
This commit is contained in:
Sarah Hoffmann
2024-01-26 17:26:29 +01:00
parent bfc7acbb18
commit 9627352ee4
3 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib-sql/functions/placex_triggers.sql
View File

@@ -1241,7 +1241,9 @@ BEGIN
OR ST_GeometryType(NEW.geometry) not in ('ST_LineString','ST_MultiLineString') OR ST_GeometryType(NEW.geometry) not in ('ST_LineString','ST_MultiLineString')
OR ST_Length(NEW.geometry) < 0.02) OR ST_Length(NEW.geometry) < 0.02)
THEN THEN
NEW.postcode := get_nearest_postcode(NEW.country_code, NEW.geometry); NEW.postcode := get_nearest_postcode(NEW.country_code,
CASE WHEN NEW.rank_address > 25
THEN NEW.centroid ELSE NEW.geometry END);
END IF; END IF;
{% if debug %}RAISE WARNING 'place update % % finished.', NEW.osm_type, NEW.osm_id;{% endif %} {% if debug %}RAISE WARNING 'place update % % finished.', NEW.osm_type, NEW.osm_id;{% endif %}

2
test/bdd/api/reverse/queries.feature
View File

@@ -39,7 +39,7 @@ Feature: Reverse geocoding
| way | highway | | way | highway |
And result addresses contain And result addresses contain
| road | postcode | country_code | | road | postcode | country_code |
| Upper Kingston Road | 30607 | us | | Upper Kingston Road | 36067 | us |
Scenario: Interpolated house number Scenario: Interpolated house number
When sending v1/reverse at 47.118533,9.57056562 When sending v1/reverse at 47.118533,9.57056562

17
test/bdd/db/import/postcodes.feature
View File

@@ -115,6 +115,23 @@ Feature: Import of postcodes
| object | postcode | | object | postcode |
| W93 | 45023 | | W93 | 45023 |
Scenario: Road areas get postcodes from nearby named buildings without other info
Given the grid with origin US
| 10 | | | | 11 |
| 13 | | | | 12 |
| | 1 | 2 | | |
| | 4 | 3 | | |
And the named places
| osm | class | type | geometry |
| W93 | highway | pedestriant | (10,11,12,13,10) |
And the named places
| osm | class | type | addr+postcode | geometry |
| W22 | building | yes | 45023 | (1,2,3,4,1) |
When importing
Then placex contains
| object | postcode |
| W93 | 45023 |
Scenario: Roads get postcodes from nearby unnamed buildings without other info Scenario: Roads get postcodes from nearby unnamed buildings without other info
Given the grid with origin US Given the grid with origin US
| 10 | | | | 11 | | 10 | | | | 11 |