port check-for-update function to python

test/python/test_cli.py

@@ -120,7 +120,6 @@ def test_refresh_command(monkeypatch, temp_db, command, func):
     monkeypatch.setattr(nominatim.tools.refresh, func, func_mock)
 
     assert 0 == call_nominatim('refresh', '--' + command)
-
     assert func_mock.called == 1
 
 
@@ -132,14 +131,14 @@ def test_refresh_importance_computed_after_wiki_import(mock_run_legacy, temp_db)
 
 
 @pytest.mark.parametrize("params,func", [
-                         (('--init', '--no-update-functions'), 'init_replication')
+                         (('--init', '--no-update-functions'), 'init_replication'),
+                         (('--check-for-updates',), 'check_for_updates')
                          ])
 def test_replication_command(monkeypatch, temp_db, params, func):
     func_mock = MockParamCapture()
     monkeypatch.setattr(nominatim.tools.replication, func, func_mock)
 
     assert 0 == call_nominatim('replication', *params)
-
     assert func_mock.called == 1
 
 

test/python/test_db_status.py

@@ -72,3 +72,15 @@ def test_set_status_filled_table(status_table, temp_db_conn, temp_db_cursor):
 
     assert temp_db_cursor.rowcount == 1
     assert temp_db_cursor.fetchone() == [date, 456, False]
+
+
+def test_get_status_empty_table(status_table, temp_db_conn):
+    assert nominatim.db.status.get_status(temp_db_conn) == (None, None, None)
+
+
+def test_get_status_success(status_table, temp_db_conn):
+    date = dt.datetime.fromordinal(1000000).replace(tzinfo=dt.timezone.utc)
+    nominatim.db.status.set_status(temp_db_conn, date=date, seq=667, indexed=False)
+
+    assert nominatim.db.status.get_status(temp_db_conn) == \
+             (date, 667, False)

test/python/test_tools_replication.py

@@ -4,8 +4,10 @@ Tests for replication functionality.
 import datetime as dt
 
 import pytest
+from osmium.replication.server import OsmosisState
 
 import nominatim.tools.replication
+import nominatim.db.status as status
 
 OSM_NODE_DATA = """\
 <osm version="0.6" generator="OpenStreetMap server" copyright="OpenStreetMap and contributors" attribution="http://www.openstreetmap.org/copyright" license="http://opendatacommons.org/licenses/odbl/1-0/">
@@ -39,3 +41,37 @@ def test_init_replication_success(monkeypatch, status_table, place_row, temp_db_
     expected_date = dt.datetime.fromisoformat('2006-01-27T19:09:10').replace(tzinfo=dt.timezone.utc)
     assert temp_db_cursor.rowcount == 1
     assert temp_db_cursor.fetchone() == [expected_date, 234, True]
+
+
+def test_check_for_updates_empty_status_table(status_table, temp_db_conn):
+    assert nominatim.tools.replication.check_for_updates(temp_db_conn, 'https://test.io') == 254
+
+
+def test_check_for_updates_seq_not_set(status_table, temp_db_conn):
+    status.set_status(temp_db_conn, dt.datetime.now().replace(tzinfo=dt.timezone.utc))
+
+    assert nominatim.tools.replication.check_for_updates(temp_db_conn, 'https://test.io') == 254
+
+
+def test_check_for_updates_no_state(monkeypatch, status_table, temp_db_conn):
+    status.set_status(temp_db_conn,
+                      dt.datetime.now().replace(tzinfo=dt.timezone.utc),
+                      seq=345)
+
+    monkeypatch.setattr(nominatim.tools.replication.ReplicationServer,
+                        "get_state_info", lambda self: None)
+
+    assert nominatim.tools.replication.check_for_updates(temp_db_conn, 'https://test.io') == 253
+
+
+@pytest.mark.parametrize("server_sequence,result", [(344, 1), (345, 1), (346, 0)])
+def test_check_for_updates_no_new_data(monkeypatch, status_table, temp_db_conn,
+                                       server_sequence, result):
+    date = dt.datetime.now().replace(tzinfo=dt.timezone.utc)
+    status.set_status(temp_db_conn, date, seq=345)
+
+    monkeypatch.setattr(nominatim.tools.replication.ReplicationServer,
+                        "get_state_info",
+                        lambda self: OsmosisState(server_sequence, date))
+
+    assert nominatim.tools.replication.check_for_updates(temp_db_conn, 'https://test.io') == result