hans/Nominatim
1
0
Fork 1
mirror of https://github.com/osm-search/Nominatim.git synced 2026-02-26 11:08:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: more coverage for all API endpoints

Browse Source
This commit is contained in:
Sarah Hoffmann
2017-10-04 00:05:34 +02:00
parent e276ec2e94
commit 89c576fbe1
4 changed files with 41 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/PlaceLookup.php
View File

@@ -45,27 +45,16 @@ class PlaceLookup
$this->bNameDetails = $bNameDetails; $this->bNameDetails = $bNameDetails;
} }
public function setIncludePolygonAsPoints($b = true) public function setIncludePolygonAsPoints($b = true)
{ {
$this->bIncludePolygonAsPoints = $b; $this->bIncludePolygonAsPoints = $b;
} }
public function getIncludePolygonAsPoints()
{
return $this->bIncludePolygonAsPoints;
}
public function setIncludePolygonAsText($b = true) public function setIncludePolygonAsText($b = true)
{ {
$this->bIncludePolygonAsText = $b; $this->bIncludePolygonAsText = $b;
} }
public function getIncludePolygonAsText()
{
return $this->bIncludePolygonAsText;
}
public function setIncludePolygonAsGeoJSON($b = true) public function setIncludePolygonAsGeoJSON($b = true)
{ {
$this->bIncludePolygonAsGeoJSON = $b; $this->bIncludePolygonAsGeoJSON = $b;

6
test/bdd/api/details/simple.feature
View File

@@ -12,3 +12,9 @@ Feature: Object details
| N4267356889 | | N4267356889 |
| W230804120 | | W230804120 |
| R123924 | | R123924 |
Scenario: Details with keywords
When sending details query for W78099902
| keywords |
| 1 |
Then the result is valid html

9
test/bdd/api/reverse/queries.feature
View File

@@ -23,3 +23,12 @@ Feature: Reverse geocoding
And result addresses contain And result addresses contain
| road | postcode | country_code | | road | postcode | country_code |
| West 1st Street | 57274 | us | | West 1st Street | 57274 | us |
Scenario: Interpolated house number
When sending jsonv2 reverse coordinates -33.231795578514635,-54.38682173844428
Then results contain
| osm_type | category | type |
| way | place | house |
And result addresses contain
| house_number | road |
| 1410 | Juan Antonio Lavalleja |

27
test/bdd/api/search/queries.feature
View File

@@ -44,6 +44,17 @@ Feature: Search queries
| country | Deutschland | | country | Deutschland |
| country_code | de | | country_code | de |
Scenario: With missing housenumber search falls back to road
When sending json search query "342 rocha, santa lucia" with address
Then address of result 0 is
| type | value |
| road | Rocha |
| city | Santa Lucía |
| state | Canelones |
| postcode | 90700 |
| country | Uruguay |
| country_code | uy |
@Tiger @Tiger
Scenario: TIGER house number Scenario: TIGER house number
When sending json search query "323 22nd Street Southwest, Huron" When sending json search query "323 22nd Street Southwest, Huron"
@@ -91,11 +102,25 @@ Feature: Search queries
| amenity | restaurant | | amenity | restaurant |
Scenario: Arbitrary key/value search near given coordinate Scenario: Arbitrary key/value search near given coordinate
When sending json search query "[man_made=mast] 47.15739,9.61264" When sending json search query "[man_made=mast] 47.15739° N 9.61264° E"
Then results contain Then results contain
| class | type | | class | type |
| man_made | mast | | man_made | mast |
Scenario: Arbitrary key/value search near given coordinate and named place
When sending json search query "[man_made=mast] amerlugalpe 47° 9′ 26″ N 9° 36′ 45″ E"
Then results contain
| class | type |
| man_made | mast |
Scenario: Name search near given coordinate
When sending json search query "amerlugalpe, N 47.15739° E 9.61264°"
Then exactly 1 result is returned
Scenario: Name search near given coordinate without result
When sending json search query "amerlugalpe, N 47 15 7 W 9 61 26"
Then exactly 0 results are returned
Scenario: Arbitrary key/value search near a road Scenario: Arbitrary key/value search near a road
When sending json search query "[leisure=table_soccer_table] immenbusch" When sending json search query "[leisure=table_soccer_table] immenbusch"
Then results contain Then results contain