From 21ef3be4338942af2571a3362447d606e299d031 Mon Sep 17 00:00:00 2001 From: Sarah Hoffmann Date: Fri, 11 Jul 2025 11:25:14 +0200 Subject: [PATCH 1/2] fix direction factor computation on empty strings --- src/nominatim_api/search/query.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nominatim_api/search/query.py b/src/nominatim_api/search/query.py index 092bd586..0d3658a8 100644 --- a/src/nominatim_api/search/query.py +++ b/src/nominatim_api/search/query.py @@ -324,7 +324,7 @@ class QueryStruct: of each node. """ n = len(self.nodes) - 1 - if n == 1 or n >= 50: + if n <= 1 or n >= 50: self.dir_penalty = 0 elif n == 2: self.dir_penalty = (self.nodes[1].name_address_ratio() From 26903aec0be99308bf174398620d714157f4e09f Mon Sep 17 00:00:00 2001 From: Sarah Hoffmann Date: Fri, 11 Jul 2025 14:16:48 +0200 Subject: [PATCH 2/2] add BDD test for empty queries --- test/bdd/features/api/search/simple.feature | 1 + 1 file changed, 1 insertion(+) diff --git a/test/bdd/features/api/search/simple.feature b/test/bdd/features/api/search/simple.feature index 3dc76922..2780d1ba 100644 --- a/test/bdd/features/api/search/simple.feature +++ b/test/bdd/features/api/search/simple.feature @@ -21,6 +21,7 @@ Feature: Simple Tests | %#$@*&l;der#$! | | 234.23.14.5 | | aussenstelle universitat lichtenstein wachterhaus aussenstelle universitat lichtenstein wachterhaus aussenstelle universitat lichtenstein wachterhaus aussenstelle universitat lichtenstein wachterhaus | + | . | Scenario: Empty XML search When sending v1/search with format xml