hans/Nominatim
1
0
Fork 1
mirror of https://github.com/osm-search/Nominatim.git synced 2026-03-06 18:14:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

return place_id link to details when not an OSM object

Browse Source 
Stop-gap solution to find the right object for Tiger and
interpolation objects.
This commit is contained in:
Sarah Hoffmann
2020-02-09 15:45:38 +01:00
parent 3737712044
commit 57ae3d03a1
2 changed files with 58 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/output.php
View File

@@ -48,5 +48,5 @@ function detailsPermaLink($aFeature, $sRefText = false)
$sLabel = $sRefText ? $sRefText : $sOSMType.' '.$aFeature['osm_id']; $sLabel = $sRefText ? $sRefText : $sOSMType.' '.$aFeature['osm_id'];
return '<a href="details.php?osmtype='.$aFeature['osm_type'].'&osmid='.$aFeature['osm_id'].'&class='.$aFeature['class'].'">'.$sLabel.'</a>'; return '<a href="details.php?osmtype='.$aFeature['osm_type'].'&osmid='.$aFeature['osm_id'].'&class='.$aFeature['class'].'">'.$sLabel.'</a>';
} }
return ''; return detailsLink($aFeature, $sRefText);
} }

57
test/php/Nominatim/OutputTest.php Normal file
View File

@@ -0,0 +1,57 @@
<?php
namespace Nominatim;
require_once(CONST_BasePath.'/lib/output.php');
class OutputTest extends \PHPUnit\Framework\TestCase
{
public function testDetailsPermaLinkNode()
{
$aFeature = array('osm_type' => 'N', 'osm_id'=> 38274, 'class' => 'place');
$this->assertSame(
detailsPermaLink($aFeature),
'<a href="details.php?osmtype=N&osmid=38274&class=place">node 38274</a>'
);
}
public function testDetailsPermaLinkWay()
{
$aFeature = array('osm_type' => 'W', 'osm_id'=> 65, 'class' => 'highway');
$this->assertSame(
detailsPermaLink($aFeature),
'<a href="details.php?osmtype=W&osmid=65&class=highway">way 65</a>'
);
}
public function testDetailsPermaLinkRelation()
{
$aFeature = array('osm_type' => 'R', 'osm_id'=> 9908, 'class' => 'waterway');
$this->assertSame(
detailsPermaLink($aFeature),
'<a href="details.php?osmtype=R&osmid=9908&class=waterway">relation 9908</a>'
);
}
public function testDetailsPermaLinkTiger()
{
$aFeature = array('osm_type' => 'T', 'osm_id'=> 2, 'place_id' => 334);
$this->assertSame(
detailsPermaLink($aFeature, 'foo'),
'<a href="details.php?place_id=334">foo</a>'
);
}
public function testDetailsPermaLinkInterpolation()
{
$aFeature = array('osm_type' => 'I', 'osm_id'=> 400, 'place_id' => 3);
$this->assertSame(
detailsPermaLink($aFeature, 'foo'),
'<a href="details.php?place_id=3">foo</a>'
);
}
}