hans/Nominatim
1
0
Fork 1
mirror of https://github.com/osm-search/Nominatim.git synced 2026-02-15 10:57:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

improve scaffolding for API unit tests

Browse Source 
Use the static table definition to create the test database.
Add helper function to simplify filling the tables.
This commit is contained in:
Sarah Hoffmann
2023-02-01 10:22:53 +01:00
parent df65c10360
commit 370c9b38c0
2 changed files with 51 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
test/python/api/test_api_status.py
View File

@@ -2,7 +2,7 @@
#
# This file is part of Nominatim. (https://nominatim.org)
#
# Copyright (C) 2022 by the Nominatim developer community.
# Copyright (C) 2023 by the Nominatim developer community.
# For a full list of authors see the git log.
"""
Tests for the status API call.
@@ -12,15 +12,10 @@ import datetime as dt
import pytest
from nominatim.version import NOMINATIM_VERSION, NominatimVersion
from nominatim.api import NominatimAPI
import nominatim.api as napi
def test_status_no_extra_info(apiobj, table_factory):
table_factory('import_status',
definition="lastimportdate timestamp with time zone NOT NULL")
table_factory('nominatim_properties',
definition='property TEXT, value TEXT')
result = apiobj.status()
def test_status_no_extra_info(apiobj):
result = apiobj.api.status()
assert result.status == 0
assert result.message == 'OK'
@@ -29,27 +24,26 @@ def test_status_no_extra_info(apiobj, table_factory):
assert result.data_updated is None
def test_status_full(apiobj, table_factory):
table_factory('import_status',
definition="lastimportdate timestamp with time zone NOT NULL",
content=(('2022-12-07 15:14:46+01',),))
table_factory('nominatim_properties',
definition='property TEXT, value TEXT',
content=(('database_version', '99.5.4-2'), ))
def test_status_full(apiobj):
import_date = dt.datetime(2022, 12, 7, 14, 14, 46, 0, tzinfo=dt.timezone.utc)
apiobj.add_data('import_status',
[{'lastimportdate': import_date}])
apiobj.add_data('properties',
[{'property': 'database_version', 'value': '99.5.4-2'}])
result = apiobj.status()
result = apiobj.api.status()
assert result.status == 0
assert result.message == 'OK'
assert result.software_version == NOMINATIM_VERSION
assert result.database_version == NominatimVersion(99, 5, 4, 2)
assert result.data_updated == dt.datetime(2022, 12, 7, 14, 14, 46, 0, tzinfo=dt.timezone.utc)
assert result.data_updated == import_date
def test_status_database_not_found(monkeypatch):
monkeypatch.setenv('NOMINATIM_DATABASE_DSN', 'dbname=rgjdfkgjedkrgdfkngdfkg')
api = NominatimAPI(Path('/invalid'), {})
api = napi.NominatimAPI(Path('/invalid'), {})
result = api.status()