further refactor setup to keep function small

This commit is contained in:
Sarah Hoffmann
2021-10-26 10:57:51 +02:00
parent 1cf14a8e94
commit 2c4b798f9b

View File

@@ -133,10 +133,7 @@ class SetupAll:
with connect(args.config.get_libpq_dsn()) as conn: with connect(args.config.get_libpq_dsn()) as conn:
refresh.setup_website(webdir, args.config, conn) refresh.setup_website(webdir, args.config, conn)
with connect(args.config.get_libpq_dsn()) as conn: SetupAll._set_database_date(args.config.get_libpq_dsn())
SetupAll._set_database_date(conn)
properties.set_property(conn, 'database_version',
'{0[0]}.{0[1]}.{0[2]}-{0[3]}'.format(NOMINATIM_VERSION))
return 0 return 0
@@ -199,12 +196,16 @@ class SetupAll:
@staticmethod @staticmethod
def _set_database_date(conn): def _set_database_date(dsn):
""" Determine the database date and set the status accordingly. """ Determine the database date and set the status accordingly.
""" """
try: with connect(dsn) as conn:
dbdate = status.compute_database_date(conn) try:
status.set_status(conn, dbdate) dbdate = status.compute_database_date(conn)
LOG.info('Database is at %s.', dbdate) status.set_status(conn, dbdate)
except Exception as exc: # pylint: disable=broad-except LOG.info('Database is at %s.', dbdate)
LOG.error('Cannot determine date of database: %s', exc) except Exception as exc: # pylint: disable=broad-except
LOG.error('Cannot determine date of database: %s', exc)
properties.set_property(conn, 'database_version',
'{0[0]}.{0[1]}.{0[2]}-{0[3]}'.format(NOMINATIM_VERSION))