From d364afdf3ba2c3b59498325c43128005ef361720 Mon Sep 17 00:00:00 2001
From: Sarah Hoffmann <lonvia@denofr.de>
Date: Wed, 8 Jul 2020 08:32:46 +0200
Subject: [PATCH 1/2] reenable debug parameter

The parameter got lost when switching to website settings.
Given that the use of a fixed parameter is limited,
debugging output can now only be set via the URL parameter.
---
 cmake/website.tmpl       | 2 ++
 lib/setup/SetupClass.php | 1 -
 settings/defaults.php    | 2 --
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/cmake/website.tmpl b/cmake/website.tmpl
index 8692280d..8b946584 100755
--- a/cmake/website.tmpl
+++ b/cmake/website.tmpl
@@ -1,3 +1,5 @@
 <?php
+@define('CONST_Debug', (isset($_GET['debug']) && $_GET['debug']));
 require_once(dirname(dirname(__FILE__)).'/website/settings-frontend.php');
+
 require_once(CONST_BasePath.'/@script_source@');
diff --git a/lib/setup/SetupClass.php b/lib/setup/SetupClass.php
index 16c48729..ea47e828 100755
--- a/lib/setup/SetupClass.php
+++ b/lib/setup/SetupClass.php
@@ -707,7 +707,6 @@ class SetupFunctions
 @define('CONST_BasePath', '".CONST_BasePath."');
 if (file_exists(getenv('NOMINATIM_SETTINGS'))) require_once(getenv('NOMINATIM_SETTINGS'));
 
-@define('CONST_Debug', ". (CONST_Debug? 'true' : 'false').");
 @define('CONST_Database_DSN', '".CONST_Database_DSN."'); // or add ;host=...;port=...;user=...;password=...
 @define('CONST_Default_Language', ".(CONST_Default_Language ? 'true' : 'false').");
 @define('CONST_Default_Lat', ".CONST_Default_Lat.");
diff --git a/settings/defaults.php b/settings/defaults.php
index f5220cd0..7a7a1e6f 100644
--- a/settings/defaults.php
+++ b/settings/defaults.php
@@ -3,10 +3,8 @@
 @define('CONST_InstallPath', '@CMAKE_BINARY_DIR@');
 if (file_exists(getenv('NOMINATIM_SETTINGS'))) require_once(getenv('NOMINATIM_SETTINGS'));
 if (file_exists(CONST_InstallPath.'/settings/local.php')) require_once(CONST_InstallPath.'/settings/local.php');
-if (isset($_GET['debug']) && $_GET['debug']) @define('CONST_Debug', true);
 
 // General settings
-@define('CONST_Debug', false);
 @define('CONST_Database_DSN', 'pgsql:dbname=nominatim'); // or add ;host=...;port=...;user=...;password=...
 @define('CONST_Database_Web_User', 'www-data');
 @define('CONST_Database_Module_Path', CONST_InstallPath.'/module');

From f376f452773ba0c9d99337c9c212cd1ad02da65b Mon Sep 17 00:00:00 2001
From: Sarah Hoffmann <lonvia@denofr.de>
Date: Wed, 8 Jul 2020 08:38:11 +0200
Subject: [PATCH 2/2] default language is a string when not set to false

---
 lib/setup/SetupClass.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/setup/SetupClass.php b/lib/setup/SetupClass.php
index ea47e828..0ffb9f35 100755
--- a/lib/setup/SetupClass.php
+++ b/lib/setup/SetupClass.php
@@ -708,7 +708,7 @@ class SetupFunctions
 if (file_exists(getenv('NOMINATIM_SETTINGS'))) require_once(getenv('NOMINATIM_SETTINGS'));
 
 @define('CONST_Database_DSN', '".CONST_Database_DSN."'); // or add ;host=...;port=...;user=...;password=...
-@define('CONST_Default_Language', ".(CONST_Default_Language ? 'true' : 'false').");
+@define('CONST_Default_Language', ".(CONST_Default_Language ? ("'".CONST_Default_Language."'") : 'false').");
 @define('CONST_Default_Lat', ".CONST_Default_Lat.");
 @define('CONST_Default_Lon', ".CONST_Default_Lon.");
 @define('CONST_Default_Zoom', ".CONST_Default_Zoom.");