From 00094c43d1690547697f435374bd3a7d939c993f Mon Sep 17 00:00:00 2001 From: Sarah Hoffmann Date: Fri, 21 May 2021 22:39:56 +0200 Subject: [PATCH 1/2] enable Tiger BDD API test for legacy_icu --- test/bdd/steps/nominatim_environment.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/bdd/steps/nominatim_environment.py b/test/bdd/steps/nominatim_environment.py index 0e986f21..1deb43f3 100644 --- a/test/bdd/steps/nominatim_environment.py +++ b/test/bdd/steps/nominatim_environment.py @@ -198,8 +198,7 @@ class NominatimEnvironment: try: self.run_nominatim('import', '--osm-file', str(self.api_test_file)) - if self.tokenizer != 'legacy_icu': - self.run_nominatim('add-data', '--tiger-data', str((testdata / 'tiger').resolve())) + self.run_nominatim('add-data', '--tiger-data', str((testdata / 'tiger').resolve())) self.run_nominatim('freeze') if self.tokenizer != 'legacy_icu': From 8f3429939ff0566d9ca848d3909540e4bb92b474 Mon Sep 17 00:00:00 2001 From: Sarah Hoffmann Date: Fri, 21 May 2021 22:40:22 +0200 Subject: [PATCH 2/2] CI: run BDD tests with legacy_icu tokenizer --- .github/workflows/ci-tests.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/ci-tests.yml b/.github/workflows/ci-tests.yml index 3d473751..b60507bc 100644 --- a/.github/workflows/ci-tests.yml +++ b/.github/workflows/ci-tests.yml @@ -71,6 +71,11 @@ jobs: vendor/bin/phpcov merge --clover ../../coverage-bdd.xml ./cov working-directory: Nominatim/test/bdd + - name: BDD tests (legacy_icu tokenizer) + run: | + behave -DREMOVE_TEMPLATE=1 -DBUILDDIR=$GITHUB_WORKSPACE/build -DTOKENIZER=legacy_icu --format=progress3 + working-directory: Nominatim/test/bdd + - name: Upload coverage to Codecov uses: codecov/codecov-action@v1 with: